Skip to content

fix: fix ODEProblem construction during precompilation with eval_expression = true #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 13, 2025
Merged

fix: fix ODEProblem construction during precompilation with eval_expression = true #3957

merged 11 commits into from
Oct 13, 2025

Conversation

AayushSabharwal
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

Benchmark Results (Julia vlts)

Time benchmarks
master 5f99265... master / 5f99265...
ODEProblem 0.0847 ± 0.0061 s 0.109 ± 0.0076 s 0.774 ± 0.078
init 0.0576 ± 0.0014 ms 0.0593 ± 0.0022 ms 0.971 ± 0.043
large_parameter_init/ODEProblem 1.07 ± 0.0026 s 1.15 ± 0.0034 s 0.927 ± 0.0036
large_parameter_init/init 0.108 ± 0.0023 ms 0.11 ± 0.0028 ms 0.99 ± 0.033
mtkcompile 0.0347 ± 0.0014 s 0.0386 ± 0.0021 s 0.899 ± 0.06
time_to_load 4.96 ± 0.01 s 5.26 ± 0.17 s 0.942 ± 0.03
Memory benchmarks
master 5f99265... master / 5f99265...
ODEProblem 0.606 M allocs: 20.6 MB 0.708 M allocs: 23.9 MB 0.865
init 0.892 k allocs: 0.0463 MB 0.892 k allocs: 0.0461 MB 1
large_parameter_init/ODEProblem 4.33 M allocs: 0.168 GB 4.5 M allocs: 0.173 GB 0.969
large_parameter_init/init 1.74 k allocs: 0.0858 MB 1.74 k allocs: 0.0857 MB 1
mtkcompile 0.237 M allocs: 8.75 MB 0.237 M allocs: 8.75 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

Benchmark Results (Julia v1)

Time benchmarks
master 5f99265... master / 5f99265...
ODEProblem 0.0887 ± 0.0053 s 0.102 ± 0.0076 s 0.868 ± 0.083
init 0.0436 ± 0.011 ms 0.0439 ± 0.011 ms 0.994 ± 0.35
large_parameter_init/ODEProblem 1.26 ± 0.044 s 1.26 ± 0.047 s 0.996 ± 0.051
large_parameter_init/init 0.0767 ± 0.016 ms 0.0766 ± 0.017 ms 1 ± 0.31
mtkcompile 0.0376 ± 0.0023 s 0.0361 ± 0.0012 s 1.04 ± 0.071
time_to_load 4.66 ± 0.008 s 4.65 ± 0.061 s 1 ± 0.013
Memory benchmarks
master 5f99265... master / 5f99265...
ODEProblem 0.618 M allocs: 19.8 MB 0.719 M allocs: 22.9 MB 0.863
init 0.797 k allocs: 30.9 kB 0.797 k allocs: 30.8 kB 1
large_parameter_init/ODEProblem 4.55 M allocs: 0.165 GB 4.8 M allocs: 0.174 GB 0.949
large_parameter_init/init 1.64 k allocs: 0.0598 MB 1.64 k allocs: 0.0597 MB 1
mtkcompile 0.242 M allocs: 8.3 MB 0.242 M allocs: 8.3 MB 1
time_to_load 0.151 k allocs: 11.5 kB 0.151 k allocs: 11.5 kB 1

@AayushSabharwal AayushSabharwal force-pushed the as/precompile-odeprob branch 4 times, most recently from 5c51b98 to c35f635 Compare October 13, 2025 06:28
@AayushSabharwal AayushSabharwal marked this pull request as ready for review October 13, 2025 17:20
@AayushSabharwal AayushSabharwal merged commit 0a12d70 into master Oct 13, 2025
41 of 51 checks passed
@AayushSabharwal AayushSabharwal deleted the as/precompile-odeprob branch October 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AayushSabharwal